fix!: Code refactoring to patch broken local dev setup #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9b4b6e. Going to use 'patch' instead
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #646 +/- ##
==========================================
- Coverage 69.74% 69.72% -0.03%
==========================================
Files 121 121
Lines 9691 9697 +6
==========================================
+ Hits 6759 6761 +2
- Misses 2932 2936 +4 ☔ View full report in Codecov by Sentry. |
illusional
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Looks good to me, great work!
Can you add more description to the PR and PR title to describe the functional output of the change?
The linting has also flagged:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing metamist/graphql/__init__.py
Fixing openapi-templates/configuration.mustache
Then, great to merge!
nevoodoo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses issues related to the local environment setup by skipping any
Bearertoken assignment or connection to GCP. Running the project withSM_ENVIRONMENT=LOCALwas raising auth-related GCPClient errors as the project looked for GCP credentials. Technically, this shouldn't be necessary when running locally.Changes Made
Refactored graphql/init.py for Local Environment Handling:
Modified
metamist/graphql/__init__.pyfile:When running locally, the AIOHTTPTransport instance is created without the
Authorizationheader.This modification prevents unnecessary authentication-related errors that were occurring during local execution.
Modified the
openapi-templates/configuration.mustachetemplate:Updated the OpenAPI configuration.mustache template to accommodate local environment nuances.
Specifically, the
auth_settingsclass method now returns an empty auth object when the application is running locally.